search

DynamoDS / DynamoPrimer

http://www.dynamoprimer.com
81 stars 66 forks source link

Revert "Temporarily disable PDF to fix build" #288

Closed gregmarr closed 2 years ago

gregmarr commented 2 years ago

Reverts DynamoDS/DynamoPrimer#287

QilongTang commented 2 years ago

@gregmarr If this is reverted, the job will always fail currently because of pdf generation failure, so I believe https://github.com/DynamoDS/DynamoPrimer/pull/287 is the right thing to do for now

gregmarr commented 2 years ago

Better to fail than to wipe out all the content.

QilongTang commented 2 years ago

Which I dont think is the case before but as you wish

gregmarr commented 2 years ago

CI is disabled now so it probably doesn't matter much either way. I don't have access to merge.