Improve naming & consistency for bin packing features - Githubissues

DynamoDS / RefineryToolkits

The Autodesk Refinery Toolkit

Apache License 2.0

48 stars 28 forks source link

Improve naming & consistency for bin packing features #123

Closed radumg closed 5 years ago

radumg commented 5 years ago

During the workshops that @SHKnudsen led, customers identified that the naming & consistency of BinPacking features is not very clear and should be improved.

Sample feedback
Input: Rectangles vs. rects
Name: BinPacking.Rectangles
Binpacking.Cuboid vs Pack3D
The name does not make sense: RectanglePacking or SpacePacking sounds better
Inputs: outer rectangle, number of rectangles, the rectangles (change inputs names)
Node name could be rectanglepacking.2dpacking
Bin = Container bin or outline
Rects = Rectangles or shapes or…
Input names are not clear enough (bin = container)
Consistency on order of inputs: Bin, items vs Items, Bin`
Inputs: change rects for rectangles, change bins for container/area/space
Bin terminology does not make sense (use container)

Proposed improvements

[x] rename BinPacking to Packing
[x] rename Pack2D to PackRectangles
[x] rename Pack3D to PackCuboids
[x] rename input ports : Bin>Container, rects > rectangles or items
[x] consistent order of inputs : Items, Container, (options)

radumg commented 5 years ago

Things look good in Dynamo now :