DynamoDS / RevitTestFramework

Unit Testing on Revit
119 stars 81 forks source link

Fully path assemblies #49

Closed mjkkirschner closed 8 years ago

mjkkirschner commented 8 years ago

Purpose

http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-9567 When RTF runs some tests, it first copies addins from the revit adding folder to the working directory that the user has set, in Revit 2017, these addins now point with relatives paths to some dlls in the addin's folder. After being copied those addins throw exceptions when the paths no longer point to their assemblies correctly. This PR fixes this by parsing the revit addin files that we have copied, and making the assembly elements contain full paths using the original addin file location as the new root.

I've also updated the RTF installer binary.

Declarations

Check these if you believe they are true

@sm6srw

FYIs

@jnealb @riteshchandawar @ikeough

sm6srw commented 8 years ago

LGTM!

mjkkirschner commented 8 years ago

@sm6srw should this change be merged to 2015/2016 branches as well?

sm6srw commented 8 years ago

@mjkkirschner I have not seen addin's being installed this way before, nor if this approach is supported in earlier versions of Revit. But I don't think it would hurt to also merge this 2015/2016.