search

DynamoDS / TuneUp

A profiler for Dynamo graphs
Apache License 2.0
27 stars 15 forks source link

Null Reference Crashes #22

Closed QilongTang closed 4 years ago

QilongTang commented 4 years ago

When Nora Li from Civil Team and I were setting up Tuneup for Civil Team to consume, we were getting constant crashes which all point to null object references when launching Dynamo with TuneUp. After some debugging, I found there are multiple places which could cause such crash. Here are the fixes worked on my local system and a screen shot from Nora. image

mjkkirschner commented 4 years ago

LGTM - do the tests pass?

QilongTang commented 4 years ago

@mjkkirschner Among three tests, the second passes while the other two failed at the ASM loading step during Dynamo initialization because I am using the RC for testing (Civil and Revit still on ASM beta). Here is a screenshot of the extension working with results. image

I will merge for now to unblock Civil and check back tests after ASM has been updated there.