search

DynamoDS / TuneUp

A profiler for Dynamo graphs
Apache License 2.0
27 stars 15 forks source link

[DYN-7334] Improvements following the feedback #57

Closed ivaylo-matov closed 2 weeks ago

ivaylo-matov commented 2 weeks ago

This PR aims to address some of the resent feedback on TuneUp's revised control layout. It covers all points from column "3.3" of Mural with the exception of point 3.

  1. Hepl icon removed
  2. Centers on node when selected in the TuneUp's UI
  4. Show TuneUp is present in the Extensions menu even when language is not English
  5. UI changes to match the intended design
  6. Group title foreground color auto-adjusts for contrast with the background similarly to the groups in the workspace
  7. Jagged edges removed from group nodes

image

image

image

CenterOnNodeWhenSelected

@QilongTang @reddyashish

@Amoursol @dnenov

QilongTang commented 2 weeks ago

What is the 3rd improvement? Just curious

ivaylo-matov commented 2 weeks ago

What is the 3rd improvement? Just curious

The grouped nodes are not ordered correctly. The initial execution of the graph works fine, but when you close and reopen it, the group and total-group-time nodes are displayed at the bottom of the grid. The order is correct if you re-execute the graph or sort the headers. The code is sorting the collection correctly, but there seems to be an issue with the UI not updating properly.

image

reddyashish commented 2 weeks ago

What is the 3rd improvement? Just curious

The grouped nodes are not ordered correctly. The initial execution of the graph works fine, but when you close and reopen it, the group and total-group-time nodes are displayed at the bottom of the grid. The order is correct if you re-execute the graph or sort the headers. The code is sorting the collection correctly, but there seems to be an issue with the UI not updating properly.

image

So I will add this to one of the open tuneup tasks and we can do that for 3.4. Changes look good. Merging this.