search

DynamoMTL / dynamo-ops

Operations base
2 stars 1 forks source link

Researching / documenting CI options for code-style and linting #46

Open thisiscab opened 8 years ago

thisiscab commented 8 years ago

https://github.com/DynamoMTL/dynamo-ops/issues/43

peterberkenbosch commented 8 years ago

We have a pretty good setup for Glossier right now.

thisiscab commented 8 years ago

Mind explaining it a little bit further? :P

peterberkenbosch commented 8 years ago

wercker and codeclimate with code coverage enabled, codeclimate will also give you the configuration files to finetune the linters and rubocop.

thisiscab commented 8 years ago

So far, I have found many different "tools"

Hound -> Give feedback directly on pull-request Rubocup -> Analyze code and give you feedback Pullreview -> Service that analyze the code from pull-request and give feedback (not configurable) linthub -> Lint your code automaticly in pull-request

TravisCI can easily integrate Rubocup TravisCI can easily integrate CodeClimate (Tool for code quality / code coverage)

Suggestion pre-commit hooks https://github.com/jish/pre-commit Integrate everything we want.

Pre-commit = throw feedback before actually pushing the code.

braidn commented 8 years ago

Never heard of 'linthub'. I shouldn't be shocked thats a service.

thisiscab commented 8 years ago

Another pre-commit bundle that seems better than the one I linked https://github.com/brigade/overcommit