Ecomm Add Fixes - Githubissues

DynamoMTL / spree_chimpy

Spree/MailChimp Integration

BSD 3-Clause "New" or "Revised" License

35 stars 123 forks source link

Closed iloveitaly closed 11 years ago

iloveitaly commented 11 years ago

I tested out the existing eCommerce integration, but it didn't work with my spree install.

Here are some things I tweaked:

The taxon locator code is more flexible. It looks through the ancestor tree and picks the first taxon that is at the top of the tree (the one right below your "taxon category", i.e. a Spree::Taxonomy)
Use price instead of cost_price. price is what the customer paid
Format the order_date. If you don't use YYYY-MM-DD mailchimp we just use the current date

johanb commented 11 years ago

Nice. We should try to beef up the test suite to prevent mistakes in the future though. Tests don't pass, could you check that out ?

iloveitaly commented 11 years ago

Fixed failing specs. Let me know if anything else is needed.

johanb commented 11 years ago

@iloveitaly looks good to me. No power to merge however. @joshnuss mind to check this out ?

joshnuss commented 11 years ago

@iloveitaly @johanb thanks guys!