search

DynamoMTL / spree_chimpy

Spree/MailChimp Integration
BSD 3-Clause "New" or "Revised" License
35 stars 123 forks source link

add support for campaign conversion for shop using api controller #35

Closed papayaah closed 10 years ago

papayaah commented 10 years ago

creates a user into mailchimp when an order is sync

bryanmtl commented 10 years ago

@mickeyren The Travis build failed. Can you make sure that the tests stay green for this?

papayaah commented 10 years ago

@bryanmtl i've put in additional code to the spec file to accommodate the new code that auto creates new users for new orders.

the test suite should pass now.

bryanmtl commented 10 years ago

Looks like it's still failing, according to Travis.

On Tue, Apr 29, 2014 at 4:37 PM, David Ang notifications@github.com wrote:

@bryanmtl https://github.com/bryanmtl i've put in additional code to the spec file to accommodate the new code that auto creates new users for new orders.

the test suite should pass now.

— Reply to this email directly or view it on GitHubhttps://github.com/DynamoMTL/spree_chimpy/pull/35#issuecomment-41728752 .

BRYAN MAHONEY

bryan@godynamo.com

http://twitter.com/#!/bryanmtl http://www.twitter.com/bryanmtl

DYNAMO

http://www.goDynamo.com http://www.godynamo.com/

http://twitter.com/dynamomtl

http://facebook.com/dynamomtl

TEL 514 499 2843 x21 | CEL 514 804 2843

439 Rue St-Pierre, Vieux-Montréal, Québec H2Y2M8 CANADA

bryanmtl commented 10 years ago

@joshnuss Any idea where this error might be coming from? The tests are all green when we run locally.

joshnuss commented 10 years ago

@bryanmtl yeah same for me, all running ok locally.

travis seems to think master is broken too, but it also passes locally

papayaah commented 10 years ago

Hi @bryanmtl

Any idea how to proceed from here? Works locally but not on Travis should you just merge anyways?