search

DynamoMTL / spree_chimpy

Spree/MailChimp Integration
BSD 3-Clause "New" or "Revised" License
35 stars 123 forks source link

Make delayed_job optional #4

Closed johanb closed 11 years ago

johanb commented 11 years ago

I'd like to explore if we can make delayed_job optional, personally I use sidekiq and maybe we can support each one dynamically based on wether or not the gems are present in the host project. What do you think @joshnuss ?

update: Hmm, I'm not an expert on delayed_job but I can't find any uses of it in the codebase other then the declared dependency. Am I missing something ?

joshnuss commented 11 years ago

Hey @johanb

Totally agree.

The plan is to have no hard dependencies on anything other than spree & hominid.

Since it is common to do this type of integration in a background job, whould be nice to support delayed_job/sidekiq, but only if they are defined?. If neither are defined we can run the code synchronously

I'll update the readme later today