search

DynamoMTL / spree_chimpy

Spree/MailChimp Integration
BSD 3-Clause "New" or "Revised" License
35 stars 123 forks source link

Banned subscribers are not catched #49

Closed frahugo closed 7 years ago

frahugo commented 10 years ago

When we subscribe a subscriber, if Mailchimp returns an error saying that the email is banned, we still flag the Spree::User as subscribed.

johanb commented 10 years ago

Good point, do you want to work out a PR ?

braidn commented 9 years ago

Working on this now all.

braidn commented 9 years ago

Alrighty @johanb and @frahugo here is a rather simple attempt at solving this. Really we shouldn't push it back into the subscribe/unsubscribe flow because we aren't subscribing, etc. I feel we should modify the User data directly when the sub fails. Thoughts?

frahugo commented 9 years ago

Interface::List was decoupled from the AR models. I think it should throw an exception and let the caller decide what to do.

braidn commented 9 years ago

@frahugo here is an example of the fail/raise solution you mentioned. What yah think?>

braidn commented 9 years ago

bump on this @frahugo / @johanb any opinion on the error throw and updating the User object?