frahugo
commented
9 years ago You sure can merge those changes... they are working in in production for Glossier.
Wll then point the Glossier gemfile to the dynamomtl repo when you're done.
thanks
Le Oct 27, 2014 à 11:26 PM, Joshua Nussbaum notifications@github.com a écrit :
@frahugo is this good to go? would like to integrate with sprangular. merci
You can merge this Pull Request by running
git pull https://github.com/frahugo/spree_chimpy feature/mailchimp-2.0 Or view, comment on, or merge it at:
https://github.com/DynamoMTL/spree_chimpy/pull/51
Commit Summary
Use root_url as referer if missing Add JSON response to SubscribersController Map the same callback logic in Spree::Chimpy::Subscriber Make sure our tests cover the AR callbacks when subscriber a user or subscriber Fix broken spec Handle exception when unsubscribing a user not subscribed to the list Return true is exception occurs handle Mailchimp::ListNotSubscribedError when unsubscribing someone Add option send_welcome_email Fixes the #segment method Temporarily disable checks at boot Handle exception Mailchimp::ListInvalidImportError when subscribing a banned email Fix broken specs Add email format validation Make sure we add order only when order has transitionned to state Complete Use Spree 2.x method signature Save order source also if record_ms_details params is present Add some log messages Put back ensure block in engine Improve error checking during initialization Create segment only if list exists Don't overwrite subscribed attribute (might have been set by the form) Catch Mailchimp::ValidationError exception File Changes
M README.md (3) M app/controllers/spree/chimpy/subscribers_controller.rb (9) M app/models/spree/chimpy/configuration.rb (1) M app/models/spree/chimpy/subscriber.rb (15) M app/models/spree/order_decorator.rb (4) M app/models/spree/user_decorator.rb (2) M lib/generators/templates/spree_chimpy.rb (4) M lib/spree/chimpy/controller_filters.rb (4) M lib/spree/chimpy/engine.rb (2) M lib/spree/chimpy/interface/list.rb (28) M lib/spree/chimpy/interface/orders.rb (15) M lib/spree/chimpy/subscription.rb (2) M lib/spree_chimpy.rb (12) M spec/lib/list_interface_spec.rb (47) M spec/lib/subscription_spec.rb (4) M spec/models/subscriber_spec.rb (14) A spec/requests/subscribers_spec.rb (34) Patch Links:
https://github.com/DynamoMTL/spree_chimpy/pull/51.patch https://github.com/DynamoMTL/spree_chimpy/pull/51.diff — Reply to this email directly or view it on GitHub.
braidn
@frahugo is this good to go? would like to integrate with sprangular. merci