search

DynamoMTL / spree_chimpy

Spree/MailChimp Integration
BSD 3-Clause "New" or "Revised" License
35 stars 123 forks source link

Add support for Sidekiq #54

Closed bryanmtl closed 9 years ago

bryanmtl commented 9 years ago

@braidn - Chimpy ships with support for Delayed Job and I'd like to add support for our stores that are using Sidekiq.

Could you have a look at this for me?

braidn commented 9 years ago

Sure thing! Do you want to open this up to anything else? Resque or Beanstalk?

bryanmtl commented 9 years ago

Sidekiq is fine for now.

johanb commented 9 years ago

I made an attempt at this before: https://github.com/DynamoMTL/spree_chimpy/pull/18 never finished it though.

braidn commented 9 years ago

@johanb thank you! I will try and spruce it up/mess with things and see where I get.

braidn commented 9 years ago

Ok all, Sidekiq support added to the MailChimp 2.0 branch. Testing internally then will move to master.

joshnuss commented 9 years ago

Good stuff @braidn

At some point in the future we should switch to active_jobs: http://edgeguides.rubyonrails.org/active_job_basics.html

braidn commented 9 years ago

Now? Ha I like the active_jobs api a lot and think that it was a great idea

bryanmtl commented 9 years ago

It requires Rails 4.2, I believe. We'll have to wait until we've moved our sites to Spree 3.0

DanielWright commented 9 years ago

RIP state_machine

javereec commented 9 years ago

I'm encountering an issue when using Sidekiq that the payload is a plain hash where all the Symbols are cast to Strings. I've created a pull request to remedy this, look at https://github.com/DynamoMTL/spree_chimpy/pull/55

braidn commented 9 years ago

Closing this out all. Fixed up on master.