search

DynamoMTL / spree_chimpy

Spree/MailChimp Integration
BSD 3-Clause "New" or "Revised" License
35 stars 123 forks source link

refactor Spree::Chimpy::SubscribersController#create #73

Closed krzysiek1507 closed 7 years ago

braidn commented 8 years ago

@krzysiek1507 is this meant for master or a specific branch of spree?

krzysiek1507 commented 8 years ago

@braidn this PR is against master

braidn commented 8 years ago

@krzysiek1507 Yep. However, did you mean to do this against a specific branch so that it works with a specific Spree version?

krzysiek1507 commented 8 years ago

@braidn Nope. I wanted to add a possibility to update other attributes than email and subscribed.

braidn commented 8 years ago

What were your ideas for other attributes?

krzysiek1507 commented 8 years ago

@braidn I needed name

braidn commented 8 years ago

You need name in MailChimp? Could this be added to MailChimp using the merge vars?

krzysiek1507 commented 8 years ago

@braidn sorry, but I don't remember, it was 6 months ago. I can see we've added NAME to merge vars too.