Closed jkelleyj closed 8 years ago
braidn
commented
8 years ago @jkelleyj thanks for reaching out about this. I actually didn't realize that Mailchimp was retiring V2 so quickly. We should have gone to Gibbon a long time ago. Overall it's always been a (seemingly) better layer on top of their API. It would be amazing if you took a stab at the upgrade. No worries on the backwards compatibility with the API but, it would be amazing if we could keep the gem API layer the same.
jkelleyj
commented
8 years ago Cool - I'm working on a few other items at the moment, but should be able to take a pass at this in a week or two. I'll ping you with questions when I dig in further.
jkelleyj
commented
8 years ago @braidn I'm picking this up now to integrate Gibbon and setup for V3 API. There are a few tests not passing out of the gate. Three due to an expired API Key that I should be able to fix and two related to the resubscribe functionality. I'm building the feature branch off of master so it can be pulled into the stable versions. Am I doing something wrong, or are those resub specs outdated?
braidn
commented
8 years ago Thanks @jkelleyj ! Throw any legit Mailchimp key in there and it should work. The reuse specs are likely outdated, let's branch from spree 2.4. We then can make this master, deprecate support for lower versions and go from there. Thanks again!
jkelleyj
commented
8 years ago Sounds good. I'll branch from 2-stable and submit the PR against that when finished. I'll let you work the branch wizardry to true up the master branch and 3-stable from there if that's OK.
On Tue, Oct 11, 2016 at 10:20 AM, Braden Douglass notifications@github.com wrote:
Thanks @jkelleyj https://github.com/jkelleyj ! Throw any legit Mailchimp key in there and it should work. The reuse specs are likely outdated, let's branch from spree 2.4. We then can make this master, deprecate support for lower versions and go from there. Thanks again!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DynamoMTL/spree_chimpy/issues/75#issuecomment-252949287, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjW5BG20OhW7MvEBJNNuraoEbwzprDdks5qy6k-gaJpZM4Jy12_ .
braidn
commented
8 years ago Absolutely 👍
jkelleyj
commented
8 years ago Quick question - The specs are pretty heavily stubbed in the interfaces. Any objection to me adding VCR to record the actual requests and test response codes?
That would give us a bit better test coverage of the proper usage of Gibbon as things are changed going forward.
On Tue, Oct 11, 2016 at 10:31 AM, Braden Douglass notifications@github.com wrote:
Absolutely 👍
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DynamoMTL/spree_chimpy/issues/75#issuecomment-252952812, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjW5GJy9jX_MgYE3HSYw0O4Zg_rqx5wks5qy6vQgaJpZM4Jy12_ .
jkelleyj
commented
8 years ago resolving this issue via #76
jkelleyj
commented
8 years ago Closed via #76
Mailchimp is retiring their older APIs pretty soon (Dec 2016) http://us12.campaign-archive1.com/?u=165abe0a1aa09263bc6ad1397&id=7146f7c68e
Is there anyone working on updating this gem to support 3.0? It doesn't look like mailchimp has put out a wrapper yet. They say they are planning to release a wrapper, but I can't find a timeline on that to upgrade what spree_chimpy uses today from 2.0 to 3.0. http://devs.mailchimp.com/blog/a-good-api-shouldnt-need-an-sdk/
We could move to gibbon instead, as it has 3.0 support now, or we could just directly connect using something like HTTParty.
@braidn do you have a strong opinion on this? I'm happy to put together a pull request. I'd probably go with making it configurable for now w/ a default API Version of 2.0 to provide backward compatibility.