Open derekbruening opened 9 years ago
derekbruening
commented
9 years ago I am removing the nodefs build.
I am also removing PROFILE_LINKCOUNT and the linkcount build: no longer supported.
I am considering dropping the static build too, as there are many build issues with the test suite.
derekbruening
commented
9 years ago Xref #1802, #1806, #1804, #1805, #1808
After those and a number of other misc fixes, we have a ton of failures in debug builds where we run 2000+ test configurations. I filed #1807 to cover fixing those. For now, my plan is to run just ^common until we fix all long suite problems. That results in this long suite on Linux (have not focused on Windows yet):
callprof-32: all 19 tests passed
debug-internal-32: all 438 tests passed
debug-internal-64: 445 tests passed, **** 1 tests failed, of which 1 were flaky: ****
code_api|pthreads.pthreads_fork_FLAKY => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/pthreads.pthreads_fork_FLAKY (20275). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/heap.c:1405 IF_WINDOWS(doing_detach || ) heapmgt-vmheap.num_free_blocks == heapmgt-vmheap.num_blocks - unfreed_blocks || (ever_beyond_vmm heapmgt-vmheap.num_free_blocks = heapmgt-vmheap.num_blocks - unfreed_blocks)
release-external-32: all 19 tests passed
release-external-64: all 20 tests passed
release-internal-32: all 19 tests passed
release-internal-64: all 20 tests passed
vmsafe-debug-internal-32: all 28 tests passed
vmsafe-release-external-32: all 28 tests passed
vps-debug-internal-32: all 9 tests passed
vps-release-external-32: all 17 tests passed
1970.63user 283.40system 7:05.18elapsed 530%CPU (0avgtext+0avgdata 369556maxresident)kThis work got Linux green:
aae8813 i#1793 suite cleanup: remove PROFILE_LINKCOUNT 276bcfc i#1793 suite cleanup: remove static builds from suite 0bcff62 i#1793 suite cleanup: nativeexec and frontend tests are CI-only ad1a3d7 i#1793 suite cleanup: fix hotpatch early inject failure 1cb7fd4 i#1793 suite cleanup: fix security-build assertions and build failure 8433ad0 i#1793 suite cleanup: adjust the DR path to use for test of non-CI builds 01ee813 i#1793 suite cleanup: reduce tests in the long suite 917eab5 i#1793 suite cleanup: fix flaky timer tests c9380c1 i#1793 suite cleanup: nativeexec, floatpc, and client.flush 5586034 i#1793 suite cleanup: disable failing tests in long suite 86f1a81 i#1793 suite cleanup: expand release-build tests
However, Windows has a lot of problems even after all that work. Re-opening for Windows long suite failures:
debug-internal-32: 380 tests passed, **** 17 tests failed, of which 1 were flaky: ****
code_api|security-win32.codemod-threads_FLAKY => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\security-win32.codemod-threads_FLAKY.exe (7452). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\monitor.c:2007 md-last_fragment == NULL || TEST(FRAG_TEMP_PRIVATE, md-last_fragment-flags)
code_api,opt_speed|common.decode-stress => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.decode.exe (10600). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\translate.c:1644 mc.xsp == STRESS_XSP_INIT - xsp_adjust
code_api,thread_private|common.decode-stress => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.decode.exe (8852). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\translate.c:1647 !spill_xcx_outstanding || mc.xcx == (reg_t) get_tls(os_tls_offset((ushort)reg_spill_tls_offs(REG_XCX)))
code_api,thread_private,disable_traces|common.decode-stress => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.decode.exe (1228). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\translate.c:1647 !spill_xcx_outstanding || mc.xcx == (reg_t) get_tls(os_tls_offset((ushort)reg_spill_tls_offs(REG_XCX)))
code_api,thread_private,tracedump_binary|common.decode-stress => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.decode.exe (7556). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\translate.c:1647 !spill_xcx_outstanding || mc.xcx == (reg_t) get_tls(os_tls_offset((ushort)reg_spill_tls_offs(REG_XCX)))
desktop,coarse_freeze_at_exit|common.broadfun => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.broadfun.exe (12264). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.fib => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.fib.exe (5968). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.decode-bad => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.decode-bad.exe (12064). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.decode => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.decode.exe (9420). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.decode-stress => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.decode.exe (4776). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.eflags => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.eflags.exe (5904). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.floatpc => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.floatpc.exe (4376). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.floatpc_xl8all => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.floatpc.exe (9900). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.getretaddr => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.getretaddr.exe (9940). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.nativeexec => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.nativeexec.exe (1972). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.protect-dstack => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.protect-dstack.exe (11252). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.segfault => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\common.segfault.exe (4016). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false debug-internal-64: 355 tests passed, **** 13 tests failed: ****
code_api,opt_speed|common.decode-stress => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.decode.exe (6752). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\arch\interp.c:4230 bb-cur_pc == bb-exit_target
desktop,coarse_freeze_at_exit|common.broadfun => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.broadfun.exe (10972). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.fib => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.fib.exe (8316). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.decode-bad => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.decode-bad.exe (10356). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.decode => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.decode.exe (10104). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.decode-stress => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.decode.exe (4568). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.eflags => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.eflags.exe (11472). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.floatpc => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.floatpc.exe (5252). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.floatpc_xl8all => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.floatpc.exe (10372). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.getretaddr => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.getretaddr.exe (7788). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.nativeexec => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.nativeexec.exe (5400). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.protect-dstack => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.protect-dstack.exe (5508). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false
desktop,coarse_freeze_at_exit|common.segfault => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\common.segfault.exe (4500). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\options.c:1558 false callprof-32: 15 tests passed, **** 1 tests failed: ****
unit_tests
release-external-32: 344 tests passed, **** 16 tests failed, of which 1 were flaky: ****
unit_tests
code_api|win32.hookerfirst
code_api|security-win32.hooker-ntdll
code_api|client.call-retarget
code_api|client.cleancall
code_api|client.syscall
code_api|client.cbr3
code_api|client.cbr4
code_api|client.thread
code_api|client.inline
code_api|client.drwrap-test
code_api|client.drwrap-test-callconv
code_api|client.drsyms-test
code_api|client.pcache-use
code_api|client.nudge_ex
code_api|api.startstop_FLAKY
release-external-64: 310 tests passed, **** 21 tests failed, of which 1 were flaky: ****
unit_tests
client.annotation-detection.native
client.annotation-detection-opt.native
code_api|client.call-retarget
code_api|client.cleancall
code_api|client.syscall
code_api|client.annotation-detection
code_api|client.annotation-detection.full-decode
code_api|client.annotation-detection.full-decode.tiny-bb
code_api|client.annotation-detection.bb-truncate-1
code_api|client.annotation-detection.bb-truncate-2
code_api|client.annotation-detection-opt
code_api|client.cbr3
code_api|client.cbr4
code_api|client.thread
code_api|client.inline
code_api|client.drwrap-test
code_api|client.drwrap-test-callconv
code_api|client.drsyms-test
code_api|client.nudge_ex
code_api|api.startstop_FLAKY
release-internal-32: 15 tests passed, **** 1 tests failed: ****
unit_tests
release-internal-64: 14 tests passed, **** 2 tests failed: ****
client.annotation-detection.native
client.annotation-detection-opt.native
vmsafe-debug-internal-32: 33 tests passed, **** 15 tests failed: ****
probe_api,hotp_only|common.broadfun
probe_api,hotp_only|common.fib
probe_api,hotp_only|common.decode-bad
probe_api,hotp_only|common.decode
probe_api,hotp_only|common.decode-stress
probe_api,hotp_only|common.eflags
probe_api,hotp_only|common.floatpc
probe_api,hotp_only|common.floatpc_xl8all
probe_api,hotp_only|common.getretaddr
probe_api,hotp_only|common.protect-dstack
probe_api,hotp_only|common.segfault
security_api|common.decode
security_api|common.decode-stress
security_api,code_api,probe_api|common.decode
security_api,code_api,probe_api|common.decode-stress
vmsafe-release-external-32: 23 tests passed, **** 14 tests failed: ****
unit_tests
security_api|common.decode
security_api|common.decode-stress
probe_api,hotp_only|common.broadfun
probe_api,hotp_only|common.fib
probe_api,hotp_only|common.decode-bad
probe_api,hotp_only|common.decode
probe_api,hotp_only|common.decode-stress
probe_api,hotp_only|common.eflags
probe_api,hotp_only|common.floatpc
probe_api,hotp_only|common.floatpc_xl8all
probe_api,hotp_only|common.getretaddr
probe_api,hotp_only|common.protect-dstack
probe_api,hotp_only|common.segfault
vps-debug-internal-32: 11 tests passed, **** 34 tests failed: ****
security|common.decode-bad
security|common.decode
security|common.decode-stress
security|common.floatpc_xl8all
security|common.protect-dstack
security|common.segfault
security,client|common.broadfun
security,client|common.fib
security,client|common.decode-bad
security,client|common.decode
security,client|common.decode-stress
security,client|common.eflags
security,client|common.floatpc
security,client|common.floatpc_xl8all
security,client|common.getretaddr
security,client|common.protect-dstack
security,client|common.segfault
security,low|common.broadfun
security,low|common.fib
security,low|common.decode-bad
security,low|common.decode
security,low|common.decode-stress
security,low|common.eflags
security,low|common.floatpc
security,low|common.floatpc_xl8all
security,low|common.getretaddr
security,low|common.protect-dstack
security,low|common.segfault
security,use_moduledb|common.decode-bad
security,use_moduledb|common.decode
security,use_moduledb|common.decode-stress
security,use_moduledb|common.floatpc_xl8all
security,use_moduledb|common.protect-dstack
security,use_moduledb|common.segfault
vps-release-external-32: **** 2 build errors ****
D:\derek\dr\git\src\core\win32\callback.c(6590) : error C2039: 'hook_ldr_dll_routines' : is not a member of '_options_t'
D:\derek\dr\git\src\core\win32\callback.c(6599) : error C2039: 'hook_ldr_dll_routines' : is not a member of '_options_t'
The goal is to shorten the nightly suite and get it green by removing no longer supported configurations. Refactoring them out of the code base is also on the table.