search

DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform
Other
2.62k stars 554 forks source link

DynamoRIO_RPATH requires Debug or RelWithDebInfo? #2882

Open sdconsta opened 6 years ago

sdconsta commented 6 years ago

This issue builds off of my comments here: https://github.com/DynamoRIO/drmemory/issues/2075

When using DynamoRIO_RPATH on Windows, the drpath_file's location is computed using _DR_location_suffix (see here and here). Hence the drpath_file can only be used when the build type is Debug or RelWithDebInfo, because these are the only possible values for _DR_location_suffix. Is there any reason why it shouldn't be possible to build a Release when using relative paths?

derekbruening commented 6 years ago

The DR build itself only uses Debug or RelWithDebInfo, collapsing the other Rel* together, but a client doesn't run that collapsing code and DynamoRIOConfig.cmake should support what the client is using. So this is a bug.