codereview.cmake uses upload.py when ~/.codereview_upload_cookies is expired

[derekbruening]

From reid.kle...@gmail.com on May 22, 2011 14:07:58

The cookies saved by upload.py are only cached for about a day (for me at least), so every time I run codereview.cmake, I have to:

1. Delete the cookies file to avoid hanging codereview.cmake.
2. Run upload.py manually if I want to get the patch on codereview.appspot.com.

It's quite a minor issue but I thought I should mention it.

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=459

[derekbruening]

From bruen...@google.com on May 26, 2011 07:24:49

the password prompt has been working for me on linux so this has not been an issue -- but originally it did not work and I'm assuming when it prompts for a password it doesn't work for you? I have no idea what's different in my terminal now

[derekbruening]

From qin.zhao@gmail.com on May 26, 2011 07:30:03

For my case, there is no password prompt, but I know that I need input the password then, so just type the password instead of running upload.py separately.

[derekbruening]

From bruen...@google.com on May 26, 2011 07:41:54

For my case, there is no password prompt, but I know that I need input the password then, so just type the password instead of running upload.py separately.

does the password get echoed to the console as you type it? or is it hidden as it would be if you ran upload.py natively?

[derekbruening]

From qin.zhao@gmail.com on May 26, 2011 07:47:19

It is hidden.

[derekbruening]

From bruen...@google.com on May 26, 2011 07:58:11

Hmm, I thought it was echoing for me before. Maybe that was on cygwin. So should we have codereview.cmake put out a line saying "if there's a long pause, please type your password, continuing of course only if the chars are hidden"?

Reid, do you have the same behavior as Qin?

[derekbruening]

From reid.kle...@gmail.com on May 26, 2011 10:39:17

I'll check next time I run the review script.