search

DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform
Other
2.61k stars 554 forks source link

i#6612: Add code_api|api.rseq to Linux x64 flaky test ignore list #6613

Closed edeiana closed 7 months ago

edeiana commented 7 months ago

Adds code_api|api.rseq test to Linux 64-bit ignore list in suite/runsuite_wrapper.pl.

Issue: #1807 #6185

edeiana commented 7 months ago

I'm currently unable to check if this test is actually ignored (I am missing too many things on my current machine to build DynamoRIO and its tests), but it's a one line change, so it should be easy to see if I messed up something.

Edit: all checks pass though, so it seems to be working! (assuming api.rseq was consistently failing before)

edeiana commented 7 months ago

However, looking at the output of github action: "ci-x86/x86-64" it seems like code_api|api.rseq is still being executed.

Start 469: code_api|api.rseq 469: Test command: /home/runner/work/dynamorio/dynamorio/build_debug-internal-64/bin64/runstats "-s" "90" "-killpg" "-silent" "-env" "LD_LIBRARY_PATH" "/home/runner/work/dynamorio/dynamorio/build_debug-internal-64/lib64/debug:/home/runner/work/dynamorio/dynamorio/build_debug-internal-64/ext/lib64/debug:" "-env" "DYNAMORIO_OPTIONS" "-stderr_mask 0xC -dumpcore_mask 0 -code_api" "/home/runner/work/dynamorio/dynamorio/build_debug-internal-64/suite/tests/bin/api.rseq" 469: Test timeout computed to be: 120 469: kernel_xfer_event: type 10 469: kernel_xfer_event: type 0 469: kernel_xfer_event: type 1 469: kernel_xfer_event: type 10 469: kernel_xfer_event: type 0 469: kernel_xfer_event: type 1 469: kernel_xfer_event: type 10 469: kernel_xfer_event: type 0 469: kernel_xfer_event: type 1 469: kernel_xfer_event: type 10 469: kernel_xfer_event: type 10 469: kernel_xfer_event: type 0 469: kernel_xfer_event: type 1 469: kernel_xfer_event: type 10 469: All done 466/487 Test #469: code_api|api.rseq ................................................ Passed 1.12 sec

(https://github.com/DynamoRIO/dynamorio/actions/runs/7736068871/job/21092792695?pr=6613#step:7:40965)

Am I looking in the wrong place or is the ignoring part actually not working?

derekbruening commented 7 months ago

However, looking at the output of github action: "ci-x86/x86-64" it seems like code_api|api.rseq is still being executed.

This list only ignores a failure: it does not stop it from executing.