DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform
Other
2.63k stars 557 forks source link

i#6627: Fix multiply defined label in linux/clone.c #6628

Closed xdje42 closed 8 months ago

xdje42 commented 8 months ago

Fix having label "parent" multiply defined by replacing it with a "local label": Ref: https://sourceware.org/binutils/docs-2.42/as/Symbol-Names.html

The multiple definition is caused by make_clone3_syscall being inlined into create_thread_clone3.

Tested by running the following before/after the patch:

cd build && \ clang \ -I../dynamorio/core/drlibc \ -I../dynamorio/core/lib \ -I../dynamorio/suite/tests \ -I. \ -Iinclude \ -O1 \ -c ../dynamorio/suite/tests/linux/clone.c \ -o clone.o

Fixes #6627