search

DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform
Other
2.59k stars 552 forks source link

Revert "i#6627: Fix multiply defined label in linux/clone.c (#6628)" #6633

Closed derekbruening closed 5 months ago

derekbruening commented 5 months ago

This reverts commit 984e33548cde2b9869d16a60b15383c494470386 as it breaks our internal build.

Issue: #6627

xdje42 commented 5 months ago

Technically speaking, we don't know if it breaks the build, thus the description is inaccurate. The patch is just being conservative.

derekbruening commented 5 months ago

Technically speaking, we don't know if it breaks the build, thus the description is inaccurate. The patch is just being conservative.

We do know as it requires an extra step to remove the patch file and the patch fails to apply (by inspection, plus the patch failed when I tested my PR #6626 so we know it fails).

derekbruening commented 5 months ago

Reasonable to have TBR here IMHO to get the repo back to a pull-able state quickly.