DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform
Other
2.57k stars 552 forks source link

Move ISA mode from instr_t flags to its own dr_isa_mode_t field in instr_t #6698

Closed edeiana closed 3 months ago

edeiana commented 4 months ago

This issue aims to bring us one step closer to full dynamic ISA selection in DynamoRio (xref #1684 #1595 #6690). As of now the "flags" field in instr_t holds ISA mode information for instruction encoding. We want to move such information into a new field of instr_t "dr_isa_mode_t isa_mode;" and update the setter and getter functions for instruction ISA mode accordingly. This change increases the size of instr_t, but it also frees some bits in "flags" that can now be used for something else (note: all 4 bytes of "flags" were used, so we could use the space).