i#6698 instr_t ISA mode: move from flags to its own field

DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform

Other

2.57k stars 552 forks source link

i#6698 instr_t ISA mode: move from flags to its own field #6699

Closed edeiana closed 3 months ago

edeiana commented 4 months ago

Moves instruction-related ISA mode from instr_t flags field to a new dr_isa_mode_t field in instr_t and updates setter and getter functions for instr_t ISA mode.

Fixes #6698

edeiana commented 4 months ago

Lots of tests are currently failing. Probably due to the change in instr_t size.

edeiana commented 4 months ago

Thank you for the early review Derek! I went with your suggestion, making isa_mode a 1 byte field in instr_t. I also had to change instr_get_isa_mode() (see https://github.com/DynamoRIO/dynamorio/pull/6699#discussion_r1518834572) so they don't look the same anymore.

edeiana commented 3 months ago

code_api|tool.drcacheoff.windows-timestamps failed once (#6081) now passing.