search

Dynamoid / dynamoid

Ruby ORM for Amazon's DynamoDB.
MIT License
578 stars 195 forks source link

NewRelic Instrumentation Support? #120

Open jonathanhoskin opened 7 years ago

jonathanhoskin commented 7 years ago

Hi team Dynamoid.

Firstly, I wanted to say thanks for the awesome library, we're using it in a new production Rails app with ~200k users and it has been great!

I wanted to check if there were any plans to implement NewRelic instrumentation in Dynamoid, for the purposes of identifying the DynamoDB backend as a 'Database'.

Currently, the calls to DynamoDB are seen as an 'External' service by NewRelic (screenshot below).

If this isn't a priority, I am considering a fork to implement this myself. In this scenario, would subsequent PR for this be acceptable here?

The documentation for NewRelic::Agent::Datastores is here: https://docs.newrelic.com/docs/agents/ruby-agent/frameworks/third-party-instrumentation#h2-Custom-Datastores

Screenshot: newrelic

bglusman commented 7 years ago

@jonathanhoskin I think we're always open to PR's like this, provided it doesn't add dependencies... i.e. it should check if the classes/modules are already defined, and direct user how to activate new relix integration by including the new relic gem above dynamoid in their Gemfile probably... but @pboling has been much more actively using and maintaining then myself recently (we're gradually moving away from Dynamo, though still use it somewhat).

pboling commented 7 years ago

The previous maintainer (philipmw) no longer uses it, @bglusman is moving away from it, and my use case for Dynamo(id), is pin prick thin, and on an app that is very outdated (which is why there isn't much progress on Rails 5 issues). I only use a very small set of the features, and those I use very heavily. The library already does all the things I need, so I don't have plans to work on it much more myself, aside from reviewing PRs and encouraging others to make it better!

PRs are very much welcome, and the roadmap does not even exist. If you use it heavily and want to join the list of maintainers it would probably help the project.

jonathanhoskin commented 7 years ago

Thanks @bglusman & @pboling for your replies.

I'd be keen to contribute. I'm pretty happy with the current set of features, but things like the NewRelic integration would be things that I'd like to help improve.

For now, I'll work on my own fork that will implement the NR instrumentation, and if the PR suits the maintainer team we should have that discussion about joining the team.

pboling commented 7 years ago

@jonathanhoskin 👍 Awesome. Looking forward to seeing what you come up with! Leaving this open to link to an eventual PR.