Dynamoid / dynamoid

Ruby ORM for Amazon's DynamoDB.
MIT License
580 stars 195 forks source link

Make some methods in Dirty module public #627

Closed andrykonchin closed 1 year ago

andrykonchin commented 1 year ago

Make the following existing Dirty methods public:

These methods are public in Rails' ActiveModel - https://api.rubyonrails.org/classes/ActiveModel/Dirty.html

codecov[bot] commented 1 year ago

Codecov Report

Merging #627 (a5705a1) into master (13ee680) will decrease coverage by 0.00%. The diff coverage is 97.50%.

:exclamation: Current head a5705a1 differs from pull request most recent head 3ab00ba. Consider uploading reports for the commit 3ab00ba to get more accurate results

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   90.17%   90.17%   -0.01%     
==========================================
  Files          60       60              
  Lines        3054     3053       -1     
==========================================
- Hits         2754     2753       -1     
  Misses        300      300              
Impacted Files Coverage Δ
lib/dynamoid/dirty.rb 96.38% <97.50%> (-0.05%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
dynamoid 90%
Summary 90% (2753 / 3053)

Minimum allowed line rate is 90%