search

Dynamoid / dynamoid

Ruby ORM for Amazon's DynamoDB.
MIT License
580 stars 195 forks source link

transaction write update blocks #718

Closed ckhsponge closed 7 months ago

ckhsponge commented 8 months ago

transaction write supports blocks for updates to allow incrementing a field or adding to or deleting from a set

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.08%. Comparing base (cfa73ba) to head (6795cb5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #718 +/- ## ========================================== + Coverage 90.89% 91.08% +0.18% ========================================== Files 71 71 Lines 3414 3453 +39 ========================================== + Hits 3103 3145 +42 + Misses 311 308 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ckhsponge commented 8 months ago

@andrykonchin Here is another transaction write PR. Sorry if I'm flooding you! Feel free to delay if you want to release the other stuff first.

ckhsponge commented 7 months ago

@andrykonchin This improves the transactions that got merged a few weeks ago.

ckhsponge commented 7 months ago

@andrykonchin I added the REMOVE and removed the docs for upsert blocks. I believe this covers all the feedback but please let me know if there's anything else. Thanks!

ckhsponge commented 7 months ago

@andrykonchin I clarified some contexts and removed some docs and tests for unsupported functionality. Let me know if I missed anything.

andrykonchin commented 7 months ago

I will look at the changes a bit later.

ckhsponge commented 7 months ago

@andrykonchin Just updated the PR with those issues.

andrykonchin commented 7 months ago

Looks good. Thank you!