Closed ndjndj closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a5b7640
) 90.89% compared to head (d9dd786
) 90.89%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you! Could you please rebase the branch on master?
I’m sorry. Is this correct?
Could you please squash all commits into one? I would do it myself and push with force into your branch but it seems it's not permitted.
I'm sorry but I accidentaly broke branch. I apologize for the repeated trouble. I will create a new branch and submit a new pull request.
Hello, thank you for maintenance of this gem.
Probably related to issue #657.
I found what incorrect code sample of update method in readme.md.
.update
method does not accept conditions as arguments.https://github.com/Dynamoid/dynamoid/blob/6b96d1d9cb8cb6d011cc84d1ca4cc65f43d6a729/lib/dynamoid/persistence.rb#L232
Therefore, the following code as shown in the sample will fail.
So I removed this code sample.
thank you!