Dynamoid / dynamoid

Ruby ORM for Amazon's DynamoDB.
MIT License
573 stars 197 forks source link

Update rubocop-rspec 2.26.1 → 3.0.1 (major) #761

Closed depfu[bot] closed 1 month ago

depfu[bot] commented 1 month ago

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.27.1 → 3.0.1) · Repo · Changelog

Release Notes

3.0.1

  • Bump RuboCop requirement to +1.61. (@ydah)

3.0.0

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. (@ydah)
  • Remove RuboCop::RSpec::Language::NodePattern. (@ydah)
  • Remove RSpec/FilePath cop. (@ydah)
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@ydah)
  • Add new RSpec/MissingExpectationTargetMethod cop. (@krororo)
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@earlopain)

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

2.31.0

  • Support AutoCorrect: contextual option for LSP. (@ydah)

2.30.0

  • Add new RSpec/ExpectInLet cop. (@yasu551)

2.29.2

  • Fix beginless and endless range bug for RepeatedIncludeExample cop. (@hasghari)
  • Fix a false positive for RSpec/RepeatedSubjectCall when subject is used as argument to function call. (@K-S-A)

2.29.1

  • Fix an error in the default configuration. (@ydah)

2.29.0

  • Fix an autocorrect error for RSpec/ExpectActual. (@bquorning)
  • Add new RSpec/UndescriptiveLiteralsDescription cop. (@ydah)
  • Add new RSpec/EmptyOutput cop. (@bquorning)

2.28.0

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.7.1 → 2.7.2) · Repo · Changelog

Release Notes

2.7.2

What's Changed

  • Use rb_sym2str instead of SYM2ID by @jhawthorn in #561
  • Fix memory leak when exception is raised during JSON generation by @peterzhu2118 in #574
  • Remove references to "19" methods in JRuby by @headius in #576
  • Make OpenStruct support as optional by @hsbt in #565
  • Autoload JSON::GenericObject to avoid require ostruct warning in Ruby 3.4 by @tompng in #577
  • Warn to install ostruct if json couldn't load it by @hsbt in #578

New Contributors

Full Changelog: v2.7.1...v2.7.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parallel (indirect, 1.24.0 → 1.25.1) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.3.0.5 → 3.3.3.0) · Repo · Changelog

Release Notes

3.3.3.0 (from changelog)

API modifications:

  • Bump maintenance branches to 3.3.3 (#1023) (Koichi ITO)
  • Bump Racc to 1.8.0 (#1018) (Koichi ITO)

3.3.2.0 (from changelog)

API modifications:

  • Bump 3.3 branch to 3.3.2 (Ilya Bylich)
  • Bump 3.1 branch to 3.1.6 (#1014) (Koichi ITO)

3.3.1.0 (from changelog)

API modifications:

  • Bump parser branches to 3.0.7, 3.1.5, 3.2.4, 3.3.1 (#1011) (Ilya Bylich)
  • Use require_relative in the Parser codebase (#1003) (Koichi ITO)

Features implemented:

  • ruby{33,34}.y: allow blocks inherit anonymous args. (#1010) (Ilya Bylich)
  • Raise a more specific error when encountering an unknown magic comment encoding (#999) (Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ racc (indirect, 1.7.3 → 1.8.0) · Repo · Changelog

Release Notes

1.8.0

What's Changed

  • Generate jar to build gem by @nobu in #255
  • Fix trivial typos by @ydah in #257
  • Try to fix test failure with Ruby 3.3 by @hsbt in #260
  • Reformat the rdoc so it renders correctly both locally and on github. by @zenspider in #258
  • Allow racc cmdline to read from stdin if no path specified. by @zenspider in #259
  • Add more grammars by @nurse in #222
  • Exclude 2.5 on macos-latest by @nobu in #263
  • Drop code for Ruby 1.6 by @nobu in #264
  • Refactor command line options by @nobu in #265
  • Change encode EUC-JP to UTF-8 by @ydah in #267
  • Organize README.ja.rdoc by @ydah in #266
  • Support error_on_expect_mismatch declaration in Racc grammar file by @yui-knk in #262
  • Bump up v1.8.0 by @yui-knk in #268

New Contributors

Full Changelog: v1.7.3...v1.8.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ regexp_parser (indirect, 2.9.0 → 2.9.2) · Repo · Changelog

Release Notes

2.9.2 (from changelog)

Fixed

  • made the MFA requirement for changes to this gem visible on rubygems

2.9.1 (from changelog)

Fixed

  • fixed unnecessary $LOAD_PATH searches at load time

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop (indirect, 1.61.0 → 1.64.1) · Repo · Changelog

Release Notes

1.64.1

Bug fixes

  • #12951: Fix an error for Style/Copyright when AutocorrectNotice is missing. (@koic)
  • #12932: Fix end position of diagnostic for LSP. (@ksss)
  • #12926: Fix a false positive for Style/SuperArguments when the methods block argument is reassigned before super. (@earlopain)
  • #12931: Fix false positives for Style/RedundantLineContinuation when line continuations involve break, next, or yield with a return value. (@koic)
  • #12924: Fix false positives for Style/SendWithLiteralMethodName when public_send argument is a method name that cannot be autocorrected. (@koic)

1.64.0

New features

  • #12904: Add new either_consistent SupportedShorthandSyntax to Style/HashSyntax. (@pawelma)
  • #12842: Add new Style/SendWithLiteralMethodName cop. (@koic)
  • #12309: Add new Style/SuperArguments cop. (@earlopain)
  • #12917: Suggest correct formatter name for --format command line option. (@koic)
  • #12242: Support AllowModifiersOnAttrs option for Style/AccessModifierDeclarations. (@krororo)
  • #11585: Support AllowedMethods for Style/DocumentationMethod. (@koic)

Bug fixes

  • #7189: Fix a false positive for Style/Copyright when using multiline copyright notice. (@koic)
  • #12914: Fix a false negative for Layout/EmptyComment when using an empty comment next to code after comment line. (@koic)
  • #12919: Fix false negatives for Style/ArgumentsForwarding when forward target is super. (@koic)
  • #12923: Fix false negatives for Style/ArgumentsForwarding when forward target is safe navigation method. (@koic)
  • #12894: Fix false positives for Style/MapIntoArray when using each without receiver with << to build an array. (@koic)
  • #12876: Fix an error for the lockfile parser if a gemfile exists but a lockfile doesn't. (@earlopain)
  • #12888: Fix --no-exclude-limit generating a todo with Max config instead of listing everything out with Exclude. (@earlopain)
  • #12898: Fix an error for TargetRailsVersion when parsing from the lockfile with prerelease rails. (@earlopain)

Changes

  • #12908: Add rubocop-rspec back to suggested extensions when rspec-rails is in use. (@pirj)
  • #12884: Align output from cop.documentation_url with --show-docs-url when passing a config as argument. (@earlopain)
  • #12905: Support ActiveSupportExtensionsEnabled for Style/SymbolProc. (@koic)
  • #12897: Respect user's intentions with workspace/executeCommand LSP method. (@koic)

1.63.5

Bug fixes

  • #12877: Fix an infinite loop error for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArrayAlignment. (@koic)
  • #12873: Fix an error for Metrics/BlockLength when the CountAsOne config is invalid. (@koic)
  • #12881: Fix incorrect autocorrect when Style/NumericPredicate is used with negations. (@fatkodima)
  • #12882: Fix Layout/CommentIndentation for comment-only pattern matching. (@nekketsuuu)

1.63.4

Bug fixes

  • #12871: Fix an error for rubocop -V when .rubocop.yml contains ERB. (@earlopain)
  • #12862: Fix a false positive for Style/RedundantLineContinuation when line continuations involve return with a return value. (@koic)
  • #12664: Fix handling of textDocument/diagnostic. (@muxcmux)
  • #12865: Fix Rails Cops, which weren't reporting any violations unless running with bundle exec. (@amomchilov)

1.63.3

Bug fixes

  • #12857: Fix false negatives for Lint/UnreachableCode when using pattern matching. (@koic)
  • #12852: Fix an error for Lint/EmptyFile in formatters when using cache. (@earlopain)
  • #12848: Fix an error that occurs in RuboCop::Lockfile when the constant Bundler is uninitialized. (@koic)

Changes

  • #12855: Set custom program name for the built-in LSP server. (@koic)

1.63.2

Bug fixes

  • #12843: Fix an error for Lint/MixedCaseRange when a character between Z and a is used in the regexp range. (@koic)
  • #12846: Fix an error for RuboCop::Lockfile when there is no Bundler environment. (@koic)
  • #12832: Fix an error for Style/ArgumentsForwarding when using block arg in nested method definitions. (@koic)
  • #12841: Fix false negatives for Lint/UnreachableLoop when using pattern matching. (@koic)
  • #12835: Allow global offenses to be disabled by directive comments. (@earlopain)

Changes

  • #12845: Exclude debug/open_nonstop from Lint/Debugger by default. (@koic)

1.63.1

Bug fixes

  • #12828: Fix a false positive for Lint/AssignmentInCondition if assigning inside a method call. (@earlopain)
  • #12823: Fixed "uninitialized constant RuboCop::Lockfile::Bundler", caused when running RuboCop without bundler exec on codebases that use rubocop-rails. (@amomchilov)

1.63.0

New features

Bug fixes

  • #12769: Fix a false positive for Lint/RedundantWithIndex when calling with_index with receiver and a block. (@koic)
  • #12547: Added a comment recommending upgrading to the latest version of Rubocop in the error text when an Infinite loop detected error occurs. (@Hiroto-Iizuka)
  • #12782: Fix an error for Style/Alias with EnforcedStyle: prefer_alias when calling alias_method with fewer than 2 arguments. (@earlopain)
  • #12781: Fix an error for Style/ExactRegexpMatch when calling match without a receiver. (@earlopain)
  • #12780: Fix an error for Style/RedundantEach when using reverse_each.each without a block. (@earlopain)
  • #12731: Treat &. the same way as . for setter methods in Lint/AssignmentInCondition. (@jonas054)
  • #12793: Fix false positives for Style/RedundantLineContinuation when using line continuation with modifier. (@koic)
  • #12807: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method and others. (@koic)
  • #12796: Fix false positives for Style/EvalWithLocation when using eval with a line number from a method call or a variable. (@koic)
  • #12794: Fix false positives for Style/RedundantArgument when when single-quoted strings for cntrl character. (@koic)
  • #12797: Fix false positives for Style/RedundantLineContinuation when using line continuations with && or || operator in assignment. (@koic)
  • #12793: Fix false positives for Style/RedundantLineContinuation when multi-line continuations with operators. (@koic)
  • #12801: Fix incorrect autocorrect for Style/CollectionCompact when using delete_if. (@koic)
  • #12789: Make Style/RedundantPercentQ safe on multiline strings. (@boardfish)
  • #12802: Return global offenses for Naming/FileName and Naming/InclusiveLanguage for empty files. (@earlopain)
  • #12804: Return global offenses for Style/Copyright when the file is empty. (@earlopain)

Changes

  • #12813: Add rubocop-rspec_rails to suggested extensions and extension doc. (@ydah)
  • #12820: Add support more Capybara debugger entry points for Lint/Debugger. (@ydah)
  • #12676: Adjust offending range in LSP. (@koic)
  • #12815: Ignore Rakefile.rb in Naming/FileName in the default config. (@artur-intech)
  • #12800: Handle empty obsoletion config. (@sambostock)
  • #12721: Make Lint/Debugger aware of ruby/debug requires. (@earlopain)
  • #12817: Make rubocop -V display rubocop-rspec_rails version when using it. (@ydah)
  • #12180: Replace regex with Bundler::LockfileParser. (@amomchilov)

1.62.1

Bug fixes

  • #12761: Fix a false positive for Style/HashEachMethods when the key block argument of Enumerable#each method is unused after chunk. (@koic)
  • #12768: Fix a false positive for Style/NilComparison without receiver and EnforcedStyle: comparison. (@earlopain)
  • #12752: Fix an error for Gemspec/RequiredRubyVersion when the file is empty. (@earlopain)
  • #12770: Fix an error for Lint/RedundantWithIndex when the method has no receiver. (@earlopain)
  • #12775: Fix an error for Lint/UselessTimes when no block is present. (@earlopain)
  • #12772: Fix an error for Style/ClassVars when calling class_variable_set without arguments. (@earlopain)
  • #12773: Fix an error for Style/For with EnforcedStyle: for when no receiver. (@earlopain)
  • #12765: Fix an error for Layout/MultilineMethodCallIndentation with safe navigation and assignment method. (@earlopain)
  • #12703: Fix an error for Lint/MixedCaseRange with invalid byte sequence in UTF-8. (@earlopain)
  • #12755: Fix an exception for RedundantCurrentDirectoryInPath in case of require_relative without arguments. (@viralpraxis)
  • #12710: Fix a false negative for Layout/EmptyLineAfterMagicComment when the file is comments only. (@earlopain)
  • #12758: Fix false positives for Layout/RedundantLineBreak when using && or || after a backslash newline. (@koic)
  • #12763: Fix an infinite loop for Style/MultilineMethodSignature when there is a newline directly after the def keyword. (@earlopain)
  • #12774: Fix an infinite loop for Style/RaiseArgs with EnforcedStyle: compact when passing more than 2 arguments to raise. (@earlopain)
  • #12663: Fix Lint/Syntax getting disabled by rubocop:disable Lint/Syntax. (@earlopain)
  • #12756: Only parse target Ruby from gemspec if array elements are strings. (@davidrunger)

Changes

1.62.0

Note: This is the first RuboCop release that features (experimental) support for using Prism instead of the parser gem. Check out the docs for more details.

See also this article for additional context.

New features

  • #12600: Support Prism as a Ruby parser (experimental). (@koic)
  • #12725: Support TargetRubyVersion 3.4 (experimental). (@koic)

Bug fixes

  • #12746: Fix a false positive for Lint/ToEnumArguments when enumerator is created for another method in no arguments method definition. (@koic)
  • #12726: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method with keyword arguments without parentheses. (@koic)
  • #12738: Fix an error for Style/Encoding when magic encoding with mixed case present. (@koic)
  • #12732: Fix error determining target Ruby when gemspec required_ruby_version is read from another file. (@davidrunger)
  • #12736: Fix invalid autocorrect in Layout/SpaceInsideHashLiteralBraces. (@bquorning)
  • #12667: Don't load excluded configuration. (@jonas054)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.31.1 → 1.31.3) · Repo · Changelog

Release Notes

1.31.3 (from changelog)

Bug fixes

  • #289: Fix an error during parsing when encountering unknown encodings in the encoding magic comment. (@Earlopain)

1.31.2 (from changelog)

Bug fixes

  • #286: Improve error message for invalid parser_engine value. (@Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🗑️ rubocop-capybara (removed)

🗑️ rubocop-factory_bot (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.08%. Comparing base (3fc2fc7) to head (a5487ce). Report is 3 commits behind head on master.

:exclamation: Current head a5487ce differs from pull request most recent head 380c8e4

Please upload reports for the commit 380c8e4 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #761 +/- ## ======================================= Coverage 91.08% 91.08% ======================================= Files 71 71 Lines 3453 3453 ======================================= Hits 3145 3145 Misses 308 308 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

depfu[bot] commented 1 month ago

Closing because this update has already been applied