Closed chernandez-bunnings closed 2 months ago
Hello @chernandez-bunnings
Thanks for reporting this issue. We are looking at it. I'll let you know if we can resolve the conflicts.
Hello @chernandez-bunnings
We have released a new version v1.1.9 to fix the conflicts. You can try the new version now.
Confirming that in version . Ideally enforcing the types would be great, as I can see this new version defines those types as 1.1.9
those ts
errors are not raisedany
in those instances where there were errors. This fix works for now, for me to drop the patch. Thank you for looking into it.
If in the future a more strict type definition is supported that would be very much appreciated.
Apologies for providing a false positive confirmation. During my initial test, I didn't experience the issue. However doing a clean install, we still experience one typing error:
$ tsc
Error: node_modules/dynamsoft-capture-vision-react-native/js/DynamsoftCameraView.tsx(46,7): error TS2322: Type 'ComponentType<any>' is not assignable to type 'HostComponent<any>'.
Type 'ComponentClass<any, any>' is not assignable to type 'HostComponent<any>'.
Type 'Component<any, any, any>' is not assignable to type 'Component<any, {}, any> & Readonly<NativeMethods>'.
Type 'Component<any, any, any>' is missing the following properties from type 'Readonly<NativeMethods>': measure, measureInWindow, measureLayout, setNativeProps, and 2 more.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Hello @Dynamsoft-Henry, just wondering if there are any updates on this?
We are finalising development work for the barcode scanner. It would be great if we did not have to use a patch to ensure the tsc
passes correctly in our ci
.
I had a quick look into v1.1.12
and the issues still occurs.
@chernandez-bunnings Apologize for the late reply. We will fix it as soon as possible.
Hi @chernandez-bunnings Would you like to share your tsconfig.json file with us. So that we can confirm whether the issue is solved on you end.
Hello,
Most recent version of
dynamsoft-capture-vision-react-native@1.1.8
currently experiences typescript conflicts that have been raised during ourtsc
step.Is it possible to request the team to have a look in to the typing definitions to solve these conflicts? For now, I'm patching the package and skipping
ts
compiler from checking this filedynamsoft-capture-vision-react-native/js/DynamsoftCameraView.tsx
by adding// @ts-nocheck
at the top of the problematic file. This way ourCI
won't raise the exception. Ideally I should drop this patch as soon as the issue is resolved in the package directly.Details of the typings errors:
Note: forgot to mentioned that some of those typing conflicts present on
react-native@0.70.6