Dynamsoft / capture-vision-react-native-samples

Dynamsoft Capture Vision React-Native SDK Samples
https://www.dynamsoft.com/capture-vision/docs/introduction/
Other
15 stars 7 forks source link

Update DynamsoftCameraView.tsx #42

Closed ericphambunnings closed 7 months ago

ericphambunnings commented 9 months ago

tsc throws below error. this could be fixed by adding an in requireNativeComponent. Issue is reproducible in tsc version 4.9.5

 Type 'ComponentType<any>' is not assignable to type 'HostComponent<any>'.
  Type 'ComponentClass<any, any>' is not assignable to type 'HostComponent<any>'.
    Type 'Component<any, any, any>' is not assignable to type 'Component<any, {}, any> & Readonly<NativeMethods>'.
      Type 'Component<any, any, any>' is missing the following properties from type 'Readonly<NativeMethods>': measure, measureInWindow, measureLayout, setNativeProps, and 2 more.
Dynamsoft-Henry commented 9 months ago

Hi @ericphambunnings Thanks for your updates. We have reviewed it. However, we are not going to merge this pull request right now. We will test and add these changes in our next version.

ericphambunnings commented 9 months ago

Hi @ericphambunnings Thanks for your updates. We have reviewed it. However, we are not going to merge this pull request right now. We will test and add these changes in our next version.

Thank you