search

Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.
https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco
Apache License 2.0
164 stars 94 forks source link

Fix: for key-user-action-web that has the same name but a different domain (or actionType) create a correct template yaml file #1420

Closed jskelin closed 7 months ago

jskelin commented 8 months ago

What this PR does / Why we need it:

For key-user-action-web that has the same name but a different domain (or actionType) create a correct template yaml file

Special notes for your reviewer:

Does this PR introduce a user-facing change?

github-actions[bot] commented 8 months ago

Unit Test Results

1 779 tests  ±0   1 779 :white_check_mark: ±0   17s :stopwatch: -1s   127 suites ±0       0 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit 06652a8b. ± Comparison against base commit 5f87bb17.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both. ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownloadConfigs_FailedToFindConfigsToDownload github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_APIWithoutAnyConfigAvailableAreNotDownloaded github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_ConfigsDownloaded github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_ConfigsDownloaded_WithEmptyFile github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_ErrorFetchingConfig github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_MalformedResponseFromAnAPI github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_NoConfigsToDownloadFound_ github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_SingleConfigurationAPI ``` ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_KeyUserActionWeb_Uniqnes github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ListConfigs_returns_an_empty_list_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ListConfigs_returns_nothing_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ReadConfigById_(GET_by_ID)_details_returns_NO_configuration_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ReadConfigById_(GET_by_ID)_returns_empty_configuration_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ReadConfigById_(GET_by_ID)_returns_error_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/malformed_response_from_an_API_-_ignored ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 8 months ago

E2E Test Results

    4 files  ±0    508 suites  ±0   38m 40s :stopwatch: + 1m 42s 1 870 tests ±0  1 867 :white_check_mark:  - 1  1 :zzz: ±0  2 :x: +1  2 107 runs  ±0  2 104 :white_check_mark:  - 1  1 :zzz: ±0  2 :x: +1 

For more details on these failures, see this check.

Results for commit 7710c7a2. ± Comparison against base commit 6eb8673b.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both. ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownloadConfigs_FailedToFindConfigsToDownload github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_APIWithoutAnyConfigAvailableAreNotDownloaded github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_ConfigsDownloaded github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_ConfigsDownloaded_WithEmptyFile github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_ErrorFetchingConfig github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_MalformedResponseFromAnAPI github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_NoConfigsToDownloadFound_ github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_SingleConfigurationAPI ``` ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ TestDownload_KeyUserActionWeb_Uniqnes github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ListConfigs_returns_an_empty_list_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ListConfigs_returns_nothing_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ReadConfigById_(GET_by_ID)_details_returns_NO_configuration_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ReadConfigById_(GET_by_ID)_returns_empty_configuration_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/ReadConfigById_(GET_by_ID)_returns_error_-_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/classic ‑ Test_generalCases/malformed_response_from_an_API_-_ignored ```
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud