Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.
https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco
Apache License 2.0
164 stars 94 forks source link

fix: for key-user-action-web that has the same name but a different d… #1427

Closed jskelin closed 7 months ago

jskelin commented 7 months ago

…omain (or actionType) delete correct configuration

What this PR does / Why we need it:

To delete key-user-action-web delete.yaml is extended with actionType and domain fields. With this addition it is possible to uniquely specify configuration and delete it safely.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

github-actions[bot] commented 7 months ago

Unit Test Results

1 782 tests  +1   1 782 :white_check_mark: +1   16s :stopwatch: -1s   127 suites ±0       0 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit bd24246c. ± Comparison against base commit 43bc3485.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

E2E Test Results

    4 files   -  1    508 suites   - 127   48m 13s :stopwatch: - 20m 45s 1 883 tests  -  1  1 881 :white_check_mark:  -   1  1 :zzz: ±0  1 :x: ±0  2 120 runs   - 80  2 118 :white_check_mark:  -  80  1 :zzz: ±0  1 :x: ±0 

For more details on these failures, see this check.

Results for commit 0f8861d7. ± Comparison against base commit a96aa815.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both. ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform ``` ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ Test_KeyUserActionsWebUniqueness ```
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud