search

Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.
https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco
Apache License 2.0
164 stars 94 forks source link

Feat: Skip updates to SCIM and ALL_USERS account groups #1438

Closed arthurpitman closed 7 months ago

arthurpitman commented 7 months ago

This PR introduces a feature flag MONACO_SKIP_READ_ONLY_ACCOUNT_GROUP_UPDATES which, when enabled, causes groups owned by SCIM and ALL_USERS not be updated during deployment.

github-actions[bot] commented 7 months ago

Unit Test Results

1 784 tests  +2   1 784 :white_check_mark: +2   16s :stopwatch: ±0s   127 suites ±0       0 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit dea22cd1. ± Comparison against base commit f16211f0.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/account/deployer ‑ TestClient_UpsertGroup_Update_Existing ``` ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/account/deployer ‑ TestClient_UpsertGroup_UpdateExistingAllUsersGroupSkipped github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/account/deployer ‑ TestClient_UpsertGroup_UpdateExistingLocalGroupWorks github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/account/deployer ‑ TestClient_UpsertGroup_UpdateExistingSCIMGroupSkipped ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

E2E Test Results

    4 files   -  1    508 suites   - 127   37m 25s :stopwatch: - 29m 22s 1 885 tests +34  1 884 :white_check_mark: + 36  1 :zzz: ±0  0 :x:  - 2  2 122 runs   - 44  2 121 :white_check_mark:  -  42  1 :zzz: ±0  0 :x:  - 2 

Results for commit ad8f23e3. ± Comparison against base commit f16211f0.

This pull request removes 4 and adds 38 tests. Note that renamed tests count towards both. ``` TestMain github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/account/deployer ‑ TestClient_UpsertGroup_Update_Existing ``` ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestDeployScopedConfigurations github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestDeploySettingsWithUniqueProperties github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestDeploySettingsWithUniqueProperties_ConsidersScopes github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestIntegrationMultiProjectSingleProject github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestIntegrationMultiProject_ReturnsErrorOnInvalidProjectDefinitions github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestIntegrationScopeParameterValidation github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestIntegrationScopeParameters github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestIntegrationSettings github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestIntegrationValidationMultiProject github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestIntegrationValidationSettings … ```

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud