feat: Download dashboard and notebook documents

arthurpitman commented 6 months ago

This PR adds support for downloading documents of type dashboard and notebook, placing these within in the project in folders of the same name.

To use this feature, enable the feature flag by setting MONACO_FEAT_DOCUMENTS to true

github-actions[bot] commented 6 months ago

E2E Test Results

4 files - 1 258 suites - 125 23m 0s :stopwatch: - 23m 33s 1 904 tests + 2 1 903 :white_check_mark: + 2 1 :zzz: ±0 0 :x: ±0 1 984 runs - 78 1 983 :white_check_mark: - 78 1 :zzz: ±0 0 :x: ±0

Results for commit bb36dede. ± Comparison against base commit 19ed1688.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.

``` github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform ``` ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/download_dashboard_and_notebook_documents_works github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/no_error_downloading_documents_with_faulty_client github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/notebook_download_still_works_if_dashboard_download_fails ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

Unit Test Results

1 795 tests +4 1 795 :white_check_mark: +4 17s :stopwatch: ±0s 128 suites +1 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit bb36dede. ± Comparison against base commit 19ed1688.

:recycle: This comment has been updated with latest results.

warber commented 6 months ago

@arthurpitman looks great so far :) one thing i've noticed is that json data doesn't seem to be formatted or "prettified" before persisting, hence the whole data appears in a single line.

arthurpitman commented 6 months ago

@arthurpitman looks great so far :) one thing i've noticed is that json data doesn't seem to be formatted or "prettified" before persisting, hence the whole data appears in a single line.

That seems to be way dashboards and notebooks save their data. Do you think it is something we should consider doing for the user?

warber commented 6 months ago