Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.
https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco
Apache License 2.0
164 stars 94 forks source link

rewrite `monaco.RunWithFs` to match `main.main` #1494

Closed jskelin closed 3 months ago

jskelin commented 5 months ago

What this PR does / Why we need it:

The intention of the monaco.RunWithFs (and other variants) function, which is meant to be used in integration tests, is to behave exactly as it should behave if the same command is executed via CLI. For that reason, some minor adaptation/ refactoring is done.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

github-actions[bot] commented 5 months ago

Unit Test Results

1 892 tests  ±0   1 891 :white_check_mark: ±0   27s :stopwatch: ±0s   133 suites ±0       1 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit b4276966. ± Comparison against base commit ecab468e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 5 months ago

E2E Test Results

    4 files   -   1    268 suites   - 133   22m 1s :stopwatch: - 41m 54s 2 004 tests  -   2  2 002 :white_check_mark:  -   2  2 :zzz: ±0  0 :x: ±0  2 106 runs   - 104  2 104 :white_check_mark:  - 104  2 :zzz: ±0  0 :x: ±0 

Results for commit b4276966. ± Comparison against base commit ecab468e.

This pull request removes 2 tests. ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform ```

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud