Ci/build containers with ko - Githubissues

Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.

https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco

Apache License 2.0

164 stars 94 forks source link

Ci/build containers with ko #1568

Closed UnseenWizzard closed 2 months ago

UnseenWizzard commented 2 months ago

What this PR does / Why we need it:

This introduces ko for building the monaco container.

Why DRAFT?

Currently, this image is not 100% compatible with the previous containers, as the monaco binary is placed in a different folder. This can be resolved an a PR to ko will be made. This PR will be updated to a draft version of the fork when available. This is resolved using a forked version of ko
~~Architecture review of ko is required still~~ reviewed and approved

Special notes for your reviewer:

I believe after this change we can drop elevated privileges from the build pod and maybe use a simpler default image - be tested as a followup to getting things working though

Does this PR introduce a user-facing change?

github-actions[bot] commented 2 months ago

Unit Test Results

1 870 tests ±0 1 869 :white_check_mark: ±0 1m 56s :stopwatch: ±0s 133 suites ±0 1 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit bbfb6d87. ± Comparison against base commit 153160e0.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud