search

Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.
https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco
Apache License 2.0
164 stars 94 forks source link

fix: Don't persist `builtin:host.monitoring.mode` settings by default #1595

Closed Laubi closed 1 month ago

Laubi commented 1 month ago

What this PR does / Why we need it:

builtin:host.monitoring.mode objects are handled in a bit special way, and it's not reliable to download them. Thus, we decided to skip them during download by default. If a customer still wants to download them, they can do so by providing the MONACO_FEAT_DOWNLOAD_FILTER=false environment variable.

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

builtin:host.monitoring.mode are no longer downloaded by default.

github-actions[bot] commented 1 month ago

Unit Test Results

1 881 tests  +3   1 880 :white_check_mark: +3   1m 56s :stopwatch: -1s   133 suites ±0       1 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit e8b092e5. ± Comparison against base commit 9e95ae50.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud