Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.
https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco
Apache License 2.0
164 stars 94 forks source link

Fix/enable rate limiter for account clients #1605

Closed warber closed 1 month ago

warber commented 1 month ago

What this PR does / Why we need it:

This PR enables the rate limiter as well as retry settings when creating clients for account management.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Monaco handles HTTP 429 Too many requests errors correctly

github-actions[bot] commented 1 month ago

Unit Test Results

1 889 tests  ±0   1 888 :white_check_mark: ±0   1m 58s :stopwatch: -1s   133 suites ±0       1 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit ee099f5b. ± Comparison against base commit 7805260d.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

E2E Test Results

1 files   -     3  1 suites   - 267   11m 0s :stopwatch: - 15m 37s 2 tests  - 1 999  1 :white_check_mark:  - 1 998  0 :zzz:  - 2  1 :x: +1  2 runs   - 2 114  1 :white_check_mark:  - 2 113  0 :zzz:  - 2  1 :x: +1 

For more details on these failures, see this check.

Results for commit d07b81ee. ± Comparison against base commit dcb1f866.

This pull request removes 2001 and adds 2 tests. Note that renamed tests count towards both. ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_group github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_policy github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_user github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_FailsIfThereIsJustEmptyProjects github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_RemovesEscapeCharsAsV2AutoEscapes github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksIfNoDeleteYamlExists github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksOnFullConfiguration github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent … ``` ``` github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestDeployAndDelete_AllResources github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestIdempotenceOfDeployment ```

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud