Dynatrace / dynatrace-configuration-as-code

This tool automates deployment of Dynatrace Configuration to one or multiple Dynatrace environments.
https://docs.dynatrace.com/docs/manage/configuration-as-code/monaco
Apache License 2.0
164 stars 94 forks source link

fix: Skip caching for configs that are set to skip #1619

Closed tomazpu closed 2 weeks ago

tomazpu commented 3 weeks ago

…skip parameters set to true

What this PR does / Why we need it:

Skip caching for configs of type classic and setting that have the skip parameter set to true. As the configs won't be deployed there is no need to chache them. With this being skipped, we also prevent performance degradation compared to the previous version.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

github-actions[bot] commented 3 weeks ago

Unit Test Results

1 901 tests  ±0   1 900 ✅ ±0   1m 56s ⏱️ ±0s   134 suites ±0       1 💤 ±0      1 files   ±0       0 ❌ ±0 

Results for commit 4ce0c939. ± Comparison against base commit e88aa271.

github-actions[bot] commented 3 weeks ago

E2E Test Results

    4 files  ±0    270 suites  ±0   41m 29s ⏱️ + 18m 15s 2 016 tests ±0  2 011 ✅ ±0  2 💤 ±0  3 ❌ ±0  2 130 runs  ±0  2 125 ✅ ±0  2 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4ce0c939. ± Comparison against base commit e88aa271.

jskelin commented 3 weeks ago

Is it possible to add a test (e.g. in Test_gatherPreloadConfigTypeEntries_OneEntryPerConfigType)?

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint