Dynatrace / dynatrace-operator

Automate Kubernetes observability with Dynatrace
https://www.dynatrace.com
Apache License 2.0
163 stars 138 forks source link

expose failurePolicy in values .yaml #3535

Closed Aimen618 closed 1 week ago

Aimen618 commented 1 month ago

Is your feature request related to a problem? Please describe. the following parameter failurePolicy is hardcoded to ignore and it will be useful if we make it configurable: webhooks:

Describe the solution you'd like change it to: {{.Values.webhook.mutatingWebhook.failurePolicy}}

Describe alternatives you've considered manual patching after the chart deployment

Additional context link to code: https://github.com/Dynatrace/dynatrace-operator/blob/v1.1.0/config/helm/chart/default/templates/Common/webhook/mutatingwebhookconfiguration.yaml#L25

chrismuellner commented 1 month ago

This has the implication that a failure in the webhook or problems with the webhook deployment, in general, would block the rollout of any pods that are expected to be monitored. We have added many features to reduce the impact of failure in any of our monitoring components on the general cluster. Still, we can make this setting configurable.

We'll add this in a future release of the Operator.