Dynatrace / openkit-java

OpenKit Java Reference Implementation
Apache License 2.0
35 stars 34 forks source link

TrustAllX509TrustManager android lint warning SSLBlindTrustManager #206

Open antoni-sgz-tw opened 2 years ago

antoni-sgz-tw commented 2 years ago

Environment

Problem warning [TrustAllX509TrustManager](https://github.com/Dynatrace/openkit-java/issues/new#TrustAllX509TrustManager): Insecure TLS/SSL trust manager

Insecure TLS/SSL trust manager [../../com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class](https://github.com/Dynatrace/com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class): checkClientTrusted is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers [../../com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class](https://github.com/Dynatrace/com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class): checkServerTrusted is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers

Steps to reproduce

TheHighriser commented 2 years ago

The SSLBlindTrustManager only exists for debugging purpose. We know that this Manager is insecure, but its main purpose is to exclude certificate problems (if there are any). Per default this manager is not in use.

Do you expect us to ignore those lint warnings?

antoni-sgz-tw commented 2 years ago

If possible yes.

To work around provisionally I ignored the warning in the lint.xml file ` <?xml version="1.0" encoding="UTF-8"?>

`
TheHighriser commented 2 years ago

We will try to take care of it with the next release.