search

DyrellC / iri_js_regression

JS Regression Testing
0 stars 0 forks source link

test files share a lot of duplicate code #5

Open alon-e opened 6 years ago

alon-e commented 6 years ago

it's better to have a common script that marshals nodes and receives a function to run - the actual test. similar to the use of https://github.com/iotaledger/iri-regression-tests/blob/master/start_and_stop_a_node.sh

this way, handling the node lifecycle handling can change (for example moving to docker) and only 1 place would need to be updated.

DyrellC commented 6 years ago

Moved all file handling code into separate utility file, now there are 4:

  1. Configuration for the test object
  2. Command Builder for the jar file execution
  3. Process for process handling of the nodes
  4. File handling for redirection, deletion, creation, copy