DysonSphereMod / QOL

64 stars 34 forks source link

[RailgunsRetargeting] Error when loading a save #115

Closed Veretragna closed 3 years ago

Veretragna commented 3 years ago

2021-07-31_154350

Veretragna commented 3 years ago

Yesterday it worked just fine, today it doesn't. This error appears randomly.

Veretragna commented 3 years ago

Tried to load all autosaves, nothing works.

nyqeest commented 3 years ago

same problem here

nyqeest commented 3 years ago

hello, i found such a fix for this mod, but i don't know how to use it, could someone advise me? https://github.com/starfi5h/QOL/commit/f4040a37def393ab319130a01311071fe23c137c

Veretragna commented 3 years ago

Good news: I found a temporary workaround. I disabled the mod and all railguns, waited till all solar sails absorbed, and re-enabled the mod. After that mod continued to work. Bad news: this mod broke my savefile. Unfortunately I don't have the screenshot, but error screen shown something like "RailgunsRetargeting LateUpdate" event directly after save. I decided to not use it at all. Errors are fine as long as they don't screw up last hour of work.

gyathaar commented 3 years ago

I got bug similar also (didnt save screenshot so not 100% sure if the same one) .. disabled mod.. and noticed one of the railguns had no orbit set.. saved and loaded with mod.. and all was working fine again

Daedeross commented 3 years ago

The mod uses a non thread-safe Dictionary to store some state which has been causing this issue since the 0.7.x update to DSP, which added multi-threading. There is a pending Pull Request ( #112 ) which will fix it.

nyqeest commented 3 years ago

@Daedeross yes, but sorry for noob question, but can you explain how to use this fix? I use thunderstorm to install mods into game, and in plugin folder i have only .dll file

Daedeross commented 3 years ago

@nyqeest Until the PR is merged and a new version is released on Thunderstore by the author, you will have to build and apply the mod yourself. If you need a primer on doing that, check out this page in the wiki. The Getting Started article goes over how to manually install the mod. To get the code, you need to download or clone the PR's branch git clone https://github.com/starfi5h/QOL.git. This Steam Guide shows what you need to do to build a mod in Visual Studio (Note, wherever it says "Streets of Rogue" just insert "Dyson Sphere Program") . You mostly only need to read through step 2 & 3 since the rest has already been done.

burdoto commented 3 years ago

Closed by #111 and #112 If you do not want to compile the fix yourself, go here: https://github.com/DysonSphereMod/QOL/pull/111#issuecomment-892479463

nyqeest commented 3 years ago

@Daedeross @burdoto Thank you guys very much, I tried to compile it myself and even got a dll but unfortunately it didn't work. For me, this mod is basic to the sail shooting system, especially for larger builds. Thank you again, stay efficient :)

brokenmass commented 3 years ago

fixed in 1.3.3