Dysth / Generations

The place to report bugs and submit suggestions to the Minecraft mod Generations!
6 stars 1 forks source link

Beast Boost stat tie sometimes not behaving correctly #138

Closed soupbag closed 3 years ago

soupbag commented 3 years ago

What is the bug? Bulbapedia's Beast Boost page reads, "In the case of a tie between multiple stats, it increases one stat, prioritized in this order: Attack, Defense, Special Attack, Special Defense, and Speed." However, this doesn't seem to always hold up correctly in-game

From what I tested, Defense seems to be incorrectly prioritized over Attack, and Special Defense incorrectly over Special Attack. While as expected, Attack seems to be correctly prioritized over Speed, and Defense correctly over Special Defense

(Just for transparency, this bug wasn't found by me, it was found by the user Bo0ga. I only did some testing)

What are the steps to reproduce the bug?

For example, this Stakataka set should have 397 in both Attack and Defense and should prioritize an Attack Beast Boost over a Defense one, but seems to Beast Boost Defense instead

Stakataka @ Life Orb
Level: 100
Lonely Nature
Ability: Beast Boost
EVs: 252 HP / 252 Atk / 4 SpD
IVs: 15 Def / 0 Spe
- Trick Room
- Gyro Ball
- Stone Edge
- Earthquake

What version of Pixelmon and Forge are you on? Pixelmon Generations 8.4.2, Forge 2847

Please provide any screenshots or crash reports if needed. Stakataka-1 Stakataka-2 Stakataka-3

Guzzlord-1 Guzzlord-2

SasukeGamer commented 3 years ago

Hello :), I have been testing with your same pokemon and all seems fine for me, also the code should be correctly so probably a little error that shouldn´t happen much

image

soupbag commented 3 years ago

That's strange. Testing through it a few times today with that Stakataka set, I'm unable to reproduce it

However, I had 100% reproducibility with that set and a few others on the day that I had tested it, through several dozen tries in a few instances of singleplayer. Others had also witnessed that same bug on Harmony and were able to 100% reproduce it that day with that Stakataka set, so I'm very confident that this may not just be a one-time thing or niche issue

Will add more info if I can find any factors that may be influencing it

Edit: Tested some more on a different launcher in singleplayer and I seemed to be able to reproduce it there throughout. Restarted the game in between tries and also regenned my pixelmon.hocon file after the 8.4.2 update, of course. Still present on Harmony with a 100% rate from what I could test, though there's the difference with plugins and all that. The launcher that I had used initially in singleplayer testing seemed to not be observing the bug for a brief while today, but now appears to be. Weird lol