Dysth / Generations

The place to report bugs and submit suggestions to the Minecraft mod Generations!
6 stars 1 forks source link

Pixelmon models for CustomNPCs #203

Open dualdragoon opened 3 years ago

dualdragoon commented 3 years ago

So the CustomNPCs programmable npcs are intended to be able to use models from any mob from any loaded mods and I know for a fact that this used to work with pixelmon but at some point trying to select the pixelmon option on the model selection menu started crashing the game due to the menu trying to render what it believes to be the default of the pixelmon entity. I believe the issue is caused by CustomNPCs not providing a valid form id when it the game tries to get the proper texture and I was just wondering if there was some way a fallback could be implemented to prevent said problem from crashing, possibly by just falling back to whatever the default texture for the pixelmon is. At least that is what I believe the issue is caused by. Someone might know something I don't. Attached below is the crash log. crash-2021-06-20_22.44.09-client.txt

Lypaka-Dev commented 3 years ago

Hi! I was interested in your issue here so I did a bit of digging inside of Custom NPCs code. Unfortunately, I find that the incompatibility with Pixelmon Generations comes from Custom NPCs side and is not something that we at Generations can fix. You would have to converse with the developers of Custom NPCs to see if they would be interested in adding support of Pixelmon Generations, since their manual checking for things like "com.pixelmonmod.pixelmon" in their PixelmonHelper class only supports Pixelmon Reforged.