Dyztiny-Project / DyzCarSystem

The vehicle HUD for FiveM NUI.
GNU General Public License v3.0
20 stars 15 forks source link

Vehicle Damage Progress #2

Open rukusgaming opened 3 years ago

rukusgaming commented 3 years ago

The vehicle damage pink bar does not go down to 0 when the car is dead

l3lackMegas commented 3 years ago

Hi, @rukusgaming! Thank for open this issues.

I will try to check and test it.

l3lackMegas commented 3 years ago

Okay, I think the problem should be solved.

rukusgaming commented 3 years ago

Ok thank you

On Thu, Mar 4, 2021, 12:22 PM l3lackMegas notifications@github.com wrote:

Okay, I think the problem should be solved.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Dyztiny-Project/DyzCarSystem/issues/2#issuecomment-790827121, or unsubscribe https://github.com/notifications/unsubscribe-auth/APVWLV35VODKS62T2KOED4DTB7FVPANCNFSM4YS7H5LQ .

l3lackMegas commented 3 years ago

Please explain "car dead" means vehicle health or engine health?

rukusgaming commented 3 years ago

When the car is dead and vehicle health =0 the pink bar is still up at 90%+

rukusgaming commented 3 years ago

well engine health

FlukRocker commented 3 years ago

@rukusgaming are you try new release version?

rukusgaming commented 3 years ago

Yep downloaded and installed before I opened the new log.

On Sun, Mar 7, 2021 at 9:22 AM FlukRocker notifications@github.com wrote:

@rukusgaming https://github.com/rukusgaming are you try new release version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Dyztiny-Project/DyzCarSystem/issues/2#issuecomment-792295869, or unsubscribe https://github.com/notifications/unsubscribe-auth/APVWLV72GLRBFHDG6QHDUR3TCOK3VANCNFSM4YS7H5LQ .

cyborgassassin commented 3 years ago

I had the same issue with the damage. I managed to fix by commenting out line 26: -- SetVehicleEngineHealth(currVeh, (EntityHealth + 0.00) * 1.5);

and changing line to 48

carHealth = (GetVehicleEngineHealth(currVeh)/ GetEntityMaxHealth(currVeh)) * 100,

probably a better way of fixing it but this works for me. Great Script!

l3lackMegas commented 3 years ago

I tried commenting out line 26 as suggested by @cyborgassassin, Thank!

I have a some question. Have you use the RealisticVehicleFailure in your server? Because our scripts are not compatible with RealisticVehicleFailure.

Anyway, Please report me if It's work or not. Thank!

cyborgassassin commented 3 years ago

I used RealisticVehicleFailure and with my changes it works prefect.

https://i.imgur.com/782DbaK.png

l3lackMegas commented 3 years ago

Great! So, I'll be working on the compatibility with RealisticVehicleFailure and release new version when it's ready.

Thank you for contributing to this repo.

JohnnyS commented 3 years ago

Great! So, I'll be working on the compatibility with RealisticVehicleFailure and release new version when it's ready.

Thank you for contributing to this repo.

Any update on this?

JohnnyS commented 3 years ago

@l3lackMegas Does this tie into my issue in #10