search

DzmitrySlutskiy / EpamTraining2019

28 stars 20 forks source link

hw_06.03_android_ui @ilya-shknaj #129

Closed TashaB1 closed 5 years ago

TashaB1 commented 5 years ago

@ilya-shknaj task 1: https://github.com/DzmitrySlutskiy/EpamTraining2019/pull/52 task 2 (vk): https://github.com/TashaB1/HomeWork/pull/4 task 2 (gp): https://github.com/TashaB1/HomeWork/compare/cadd931...1e977e9 Screenshot_1553116696 Screenshot_1553116599 Screenshot_1553116699 Screenshot_1553116617 Screenshot_1553116423 Screenshot_1553114942

ilya-shknaj commented 5 years ago

Please check my comments. Also for task with GP please provide link to pull request instead of link to commits comparison. If in same pull request will be task for GP and VK it's ok

TashaB1 commented 5 years ago

@ilya-shknaj Sorry, yesterday I pulled the changes from the main repository to the wrong branch. I understood my mistake, after receiving the changes before the commit it was necessary to resolve the conflict, as well as the nuances of the work Pull requests. Made changes: task 1: #52

TashaB1 commented 5 years ago

@ilya-shknaj Thanks for the advice. Made changes: task 2: TashaB1/HomeWork#5

ilya-shknaj commented 5 years ago

Good. Just fix few issues

ilya-shknaj commented 5 years ago

@TashaB1 just kind reminder

TashaB1 commented 5 years ago

@ilya-shknaj fix task 2: https://github.com/TashaB1/HomeWork/compare/961f4c6...homework_0603_ui_android

ilya-shknaj commented 5 years ago

@TashaB1 please check my comment about viewPager

ilya-shknaj commented 5 years ago

@TashaB1 reminder

TashaB1 commented 5 years ago

@ilya-shknaj sorry check comment: https://github.com/TashaB1/HomeWork/compare/1e48a33...homework_0603_ui_android

change_text_fragment

ilya-shknaj commented 5 years ago

ok