DzmitrySlutskiy / EpamTraining2019

28 stars 20 forks source link

homework 04.03 android components @egorikftp #42

Closed DoTheMonkeyBusiness closed 5 years ago

DoTheMonkeyBusiness commented 5 years ago

@egorikftp

Part 1: https://github.com/DoTheMonkeyBusiness/EpamAndroid/pull/1

Part 2: https://github.com/DoTheMonkeyBusiness/EpamAndroid/pull/2

And look the changes in the past homework: https://github.com/DzmitrySlutskiy/EpamTraining2019/issues/9

egorikftp commented 5 years ago

@DoTheMonkeyBusiness I can't build your project, because you don't have any classes inside mysubmodule. I suggest adding library module instead git submodule

DoTheMonkeyBusiness commented 5 years ago

@egorikftp git submodule it's part of my first homework. There was a conflict in my project because I made a correction in the master branch and didn't take this into in the pull request 😬

egorikftp commented 5 years ago

Part 1: Text inside this button not saved after orientation change.

image

Part 2:

  1. Branch name should contain single _ image
  2. If I rotate device during gif animation, then I will see only color animation. Also I can't stop service in this case.

image

Please fix all issues and comments, then notify me.

DoTheMonkeyBusiness commented 5 years ago

@egorikftp redid.

egorikftp commented 5 years ago

@DoTheMonkeyBusiness

Part 1 - good Part 2 - good

🙂