search

DzmitrySlutskiy / EpamTraining2019

28 stars 20 forks source link

Homework_06.03_view_components @egorikftp #64

Closed DoTheMonkeyBusiness closed 5 years ago

DoTheMonkeyBusiness commented 5 years ago

@egorikftp

Part 1: https://github.com/DzmitrySlutskiy/EpamTraining2019/pull/63

Part 2 VK: https://github.com/DoTheMonkeyBusiness/EpamAndroid/pull/3/files

Part 2 Podcasts: https://github.com/DoTheMonkeyBusiness/EpamAndroid/pull/4/files

Part 1: Screenshot_1552063667

Part 2:

superfluous overlay due to the fact that couldn't fasten the tablayut on the top Screenshot_1552231552 Screenshot_1552231559

Screenshot_1552231610 Screenshot_1552231619

Screenshot_1552231774 Screenshot_1552231778

Part 2: Screenshot_1552421850 Screenshot_1552421939 Screenshot_1552421910

egorikftp commented 5 years ago

@DoTheMonkeyBusiness

Part 1: One question about extracting layout

Part 2: VK - Very bag code formatting. UI is ok Part 2: Podcasts - Not saw fully, please also align all code (the same comments from VK)

Please notify me after fixing all comments and issues

DoTheMonkeyBusiness commented 5 years ago

@egorikftp redid

egorikftp commented 5 years ago

@DoTheMonkeyBusiness Sorry, I forgot to push comment to Part 1.

Part 1. VK - ok Part 2. Podcasts - issues with kotlin

DoTheMonkeyBusiness commented 5 years ago

@egorikftp redid🙋🏼‍♂️. And I'm added .idea in .gitignore, but git still wants me to commit them.

egorikftp commented 5 years ago

@DoTheMonkeyBusiness Done)

Also better this code

image

replace like this)

  val adapter = ForYouPagerAdapter(supportFragmentManager).apply {
            addFragment(NewEpisodesFragment(), NEW_EPISODES_KEY)
            addFragment(InProgressFragment(), IN_PROGRESS_KEY)
            addFragment(DownloadsFragment(), DOWNLOADS_KEY)
 }