DzmitrySlutskiy / EpamTraining2019

28 stars 20 forks source link

HomeWork@egorikftp #68

Open Goncharov01 opened 5 years ago

Goncharov01 commented 5 years ago

[Hw.3] KotlinServiceBroadcast (https://github.com/Goncharov01/KotlineServiceBroadcast) [Hw.2 Part_2] CleanCodeMyCalculator (https://github.com/Goncharov01/MyCalculator/pull/1) [Hw.2 Part_1] CleanCode+Test (https://github.com/Goncharov01/EpamTraining2019/tree/homework_28.02_clean_code) [Hw.1] (https://github.com/Goncharov01/HW18.02.2019)

egorikftp commented 5 years ago

HW 1: Something strange. I see merge conflicts, but you don't resolve it correctly

image

HW 2. Part 1. You need to create pull request) I have done this manually: https://github.com/DzmitrySlutskiy/EpamTraining2019/pull/25/files

HW 2. Calculator - Good

HW 3. Don't commit .idea folder 🚯 Also better do home works in a single repository, but in different branches. Please create a pull request with your changes. Also please align all your code with style guidelines

egorikftp commented 5 years ago

@Goncharov01 Any updates?

egorikftp commented 5 years ago

@Goncharov01 Just a candly reminder

Goncharov01 commented 5 years ago

@egorikftp Sorry, a little behind the program, I'll fix everything soon.

ilya-shknaj commented 5 years ago

@Goncharov01 any updates?

egorikftp commented 5 years ago

@Goncharov01 I see no one homework from top message done correctly. What we will do?

Goncharov01 commented 5 years ago

@egorikftp At the moment, I am busy with the project, now there are some difficulties, which I am correcting, and when I do, I will definitely correct all my homework

egorikftp commented 5 years ago

cc @ilya-shknaj

ilya-shknaj commented 5 years ago

@Goncharov01 Ok, but take into account that if you don't resolve all homeworks, you will not have ability to protect your final project. And I can recommend do it before you start implementation project, because issues which we can find in homeworks, can be critical for final project