search

DzmitrySlutskiy / EpamTraining2019

28 stars 20 forks source link

HW 28.02 #75

Closed berdnikovEV closed 5 years ago

berdnikovEV commented 5 years ago

Part 1: https://github.com/berdnikovEV/EpamAndroidTrainingCalculator/compare/master...CleanCode Part 2: https://github.com/DzmitrySlutskiy/EpamTraining2019/pull/74

@DzmitrySlutskiy

DzmitrySlutskiy commented 5 years ago

@berdnikovEV could you please create pull request for part 1. I can't leave comment in code

berdnikovEV commented 5 years ago

@DzmitrySlutskiy https://github.com/berdnikovEV/EpamAndroidTrainingCalculator/pull/1

DzmitrySlutskiy commented 5 years ago

@berdnikovEV please check comments

berdnikovEV commented 5 years ago

@DzmitrySlutskiy I don't see any comments on any of the provided links

DzmitrySlutskiy commented 5 years ago

@berdnikovEV are you serious? check pull request https://github.com/berdnikovEV/EpamAndroidTrainingCalculator/pull/1

you've posted 2 links. Part 1 designed with old HW flow with compare and this one I can't leave comments Part 2 designed by new HW flow and I left at least 4 comments. Please use new flow described in https://github.com/DzmitrySlutskiy/EpamTraining2019 readme file: Homework flow: Issues should be created in this repository! Make homework in separate branch with following format: homework_DD.MM_theme_name (homework_28.02_clean_code) Open pull request in you repository and provide link in issue.

DzmitrySlutskiy commented 5 years ago

@berdnikovEV any updates on clean code HW?

DzmitrySlutskiy commented 5 years ago

@berdnikovEV reminder

DzmitrySlutskiy commented 5 years ago

@berdnikovEV are you going to close old HW?

DzmitrySlutskiy commented 5 years ago

@berdnikovEV reminder

ilya-shknaj commented 5 years ago

@berdnikovEV your request was reviewed more that month ago. Please fix issues founded by @DzmitrySlutskiy or we will have to exclude you from training

ilya-shknaj commented 5 years ago

Goodbye